-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makefile: support build with boringcrypto
to support Fips (#7275)
#7413
makefile: support build with boringcrypto
to support Fips (#7275)
#7413
Conversation
close tikv#7274 Signed-off-by: ti-chi-bot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Cabinfever_B <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #7413 +/- ##
===============================================
- Coverage 75.54% 75.52% -0.03%
===============================================
Files 332 332
Lines 33700 33721 +21
===============================================
+ Hits 25459 25468 +9
- Misses 6047 6053 +6
- Partials 2194 2200 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/merge |
@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 22483bd
|
/hold |
/unhold |
/merge |
@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/retest |
/run-test |
/run-all-tests |
c3aed4c
into
tikv:feature/release-6.5-fips
This is an automated cherry-pick of #7275
What problem does this PR solve?
Issue Number: Close #7274
What is changed and how does it work?
ref https://go.googlesource.com/go/+/dev.boringcrypto/README.boringcrypto.md and https://go.googlesource.com/go/+/dev.boringcrypto/src/crypto/tls/fipsonly/fipsonly.go
add command in makefile to build with
boringcrypto
to support Fips including pd-server、pd-ctl、pd-recoverCheck List
Tests
pd-server
pd-ctl
pd-recover
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note