Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: support build with boringcrypto to support Fips (#7275) #7413

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7275

What problem does this PR solve?

Issue Number: Close #7274

What is changed and how does it work?

ref https://go.googlesource.com/go/+/dev.boringcrypto/README.boringcrypto.md and https://go.googlesource.com/go/+/dev.boringcrypto/src/crypto/tls/fipsonly/fipsonly.go
add command in makefile to build with boringcrypto to support Fips including pd-server、pd-ctl、pd-recover

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    image
    pd-server
    image

pd-ctl
image

pd-recover
image

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Nov 22, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 22, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: Cabinfever_B <[email protected]>
@CabinfeverB CabinfeverB requested review from overvenus and removed request for JmPotato and HunDunDM November 24, 2023 02:31
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d0708f) 75.54% compared to head (22483bd) 75.52%.
Report is 1 commits behind head on release-6.5.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.5    #7413      +/-   ##
===============================================
- Coverage        75.54%   75.52%   -0.03%     
===============================================
  Files              332      332              
  Lines            33700    33721      +21     
===============================================
+ Hits             25459    25468       +9     
- Misses            6047     6053       +6     
- Partials          2194     2200       +6     
Flag Coverage Δ
unittests 75.52% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 29, 2023
@CabinfeverB
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 29, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 29, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 22483bd

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 29, 2023
@overvenus
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2023
@overvenus overvenus changed the base branch from release-6.5 to feature/release-6.5-fips December 11, 2023 03:48
@overvenus
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2023
@CabinfeverB
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CabinfeverB
Copy link
Member

/retest

@wuhuizuo
Copy link
Contributor

/run-test

@CabinfeverB
Copy link
Member

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit c3aed4c into tikv:feature/release-6.5-fips Dec 11, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants