Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(core): use internal model names everywhere #4477

Merged
merged 1 commit into from
Jan 13, 2025
Merged

build(core): use internal model names everywhere #4477

merged 1 commit into from
Jan 13, 2025

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Jan 7, 2025 •
edited
Loading

Replaces TREZOR_MODEL=T and TREZOR_MODEL=R with TREZOR_MODEL=T2T1 and TREZOR_MODEL=T2B1.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@mmilata mmilata force-pushed the mmilata/models branch 2 times, most recently from 9e657f4 to 3041bcd Compare January 8, 2025 20:50
@mmilata mmilata changed the base branch from main to obrusvit/ui-models-naming January 8, 2025 21:58
@obrusvit obrusvit force-pushed the obrusvit/ui-models-naming branch 2 times, most recently from dc10be4 to 7a1305f Compare January 9, 2025 16:51
Base automatically changed from obrusvit/ui-models-naming to main January 9, 2025 21:57
@mmilata
build(core): use internal model names everywhere
aa12e1a 
  TREZOR_MODEL=T and TREZOR_MODEL=R

no longer work, please use

  TREZOR_MODEL=T2T1 and TREZOR_MODEL=T2B1

[no changelog]
@mmilata mmilata changed the title build: internal model everywhere build(core): use internal model names everywhere Jan 9, 2025
@mmilata mmilata marked this pull request as ready for review January 9, 2025 23:13
@mmilata mmilata self-assigned this Jan 9, 2025
@mmilata mmilata requested review from obrusvit and removed request for prusnak and andrewkozlik January 9, 2025 23:14
obrusvit
obrusvit approved these changes Jan 10, 2025
View reviewed changes
core/Makefile Show resolved Hide resolved
@TychoVrahe TychoVrahe mentioned this pull request Jan 12, 2025
Merged
@obrusvit obrusvit merged commit dadff32 into main Jan 13, 2025
95 checks passed
@obrusvit obrusvit deleted the mmilata/models branch January 13, 2025 15:24
@cepetr cepetr mentioned this pull request Jan 13, 2025
Merged
@mmilata mmilata mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cepetr cepetr cepetr left review comments

@prusnak prusnak prusnak approved these changes

@obrusvit obrusvit obrusvit approved these changes

@matejcik matejcik Awaiting requested review from matejcik matejcik is a code owner

Assignees

@mmilata mmilata

Labels
None yet
Projects
Firmware
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmilata @prusnak @obrusvit @cepetr