fix bug in apply_jacobian_parabolic! for P4estMesh

[jlchan]

Previously, the same apply_jacobian_parabolic! routine was used for both P4estMesh and TreeMesh. This is incorrect, since TreeMesh assumes inverse_jacobian is constant per element, while it can vary from node to node for P4estMesh.

[github-actions]

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

• The PR has a single goal that is clear from the PR title and/or description.
• All code changes represent a single set of modifications that logically belong together.
• No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

• The code can be understood easily.
• Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
• There are no redundancies that can be removed by simple modularization/refactoring.
• There are no leftover debug statements or commented code sections.
• The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

• New functions and types are documented with a docstring or top-level comment.
• Relevant publications are referenced in docstrings (see example for formatting).
• Inline comments are used to document longer or unusual code sections.
• Comments describe intent ("why?") and not just functionality ("what?").
• If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

• The PR passes all tests.
• New or modified lines of code are covered by tests.
• New or modified tests run in less then 10 seconds.

Performance

• There are no type instabilities or memory allocations in performance-critical parts.
• If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

• The correctness of the code was verified using appropriate tests.
• If new equations/methods are added, a convergence test has been run and the results
  are posted in the PR.

Created with ❤️ by the Trixi.jl community.

[ranocha]

Thanks a lot! You should also update the CI test values for the P4estMesh accordingly

[codecov]

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (00292d1) 87.29% compared to head (ef5e1a7) 87.24%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1668      +/-   ##
==========================================
- Coverage   87.29%   87.24%   -0.06%     
==========================================
  Files         419      419              
  Lines       34140    34162      +22     
==========================================
  Hits        29802    29802              
- Misses       4338     4360      +22     

Flag	Coverage Δ
unittests	87.24% <4.17%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/solvers/dgsem_tree/dg_2d_parabolic.jl	53.28% <8.33%> (-1.58%)	⬇️
src/solvers/dgsem_tree/dg_3d_parabolic.jl	0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DanielDoehring]

Thanks!

[jlchan]

Thanks a lot! You should also update the CI test values for the P4estMesh accordingly

Thanks! Fixed (and removed a duplicate test)

[DanielDoehring]

LGTM, altough we maybe should (later (?)) add a 3D test where this actually matters (as for the 2d curved tests)

[ranocha]

Thanks