Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in apply_jacobian_parabolic! for P4estMesh #1668

Merged
merged 6 commits into from
Oct 11, 2023
Merged

fix bug in apply_jacobian_parabolic! for P4estMesh #1668

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2f2ec26
fix bug in parabolic jacobian computations
jlchan Oct 10, 2023
95c235b
formatting
jlchan Oct 10, 2023
ef5e1a7
Merge branch 'main' into jc/fix_parabolic_jacobian
ranocha Oct 10, 2023
02661cb
Merge branch 'main' into jc/fix_parabolic_jacobian
jlchan Oct 10, 2023
854badf
updating test results and removing duplicate test
jlchan Oct 10, 2023
55b2bd1
Merge remote-tracking branch 'jlchan/jc/fix_parabolic_jacobian' into …
jlchan Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/solvers/dgsem_tree/dg_2d_parabolic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,7 +935,7 @@ end
# This is because the parabolic fluxes are assumed to be of the form
# `du/dt + df/dx = dg/dx + source(x,t)`,
# where f(u) is the inviscid flux and g(u) is the viscous flux.
function apply_jacobian_parabolic!(du, mesh::Union{TreeMesh{2}, P4estMesh{2}},
function apply_jacobian_parabolic!(du, mesh::TreeMesh{2},
equations::AbstractEquationsParabolic, dg::DG, cache)
@unpack inverse_jacobian = cache.elements

Expand All @@ -951,4 +951,22 @@ function apply_jacobian_parabolic!(du, mesh::Union{TreeMesh{2}, P4estMesh{2}},

return nothing
end

function apply_jacobian_parabolic!(du, mesh::P4estMesh{2},
equations::AbstractEquationsParabolic,
dg::DG, cache)
@unpack inverse_jacobian = cache.elements

@threaded for element in eachelement(dg, cache)
for j in eachnode(dg), i in eachnode(dg)
factor = inverse_jacobian[i, j, element]

for v in eachvariable(equations)
du[v, i, j, element] *= factor
end
end
end

return nothing
end
end # @muladd
23 changes: 21 additions & 2 deletions src/solvers/dgsem_tree/dg_3d_parabolic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,8 +1125,9 @@ end
# This is because the parabolic fluxes are assumed to be of the form
# `du/dt + df/dx = dg/dx + source(x,t)`,
# where f(u) is the inviscid flux and g(u) is the viscous flux.
function apply_jacobian_parabolic!(du, mesh::Union{TreeMesh{3}, P4estMesh{3}},
equations::AbstractEquationsParabolic, dg::DG, cache)
function apply_jacobian_parabolic!(du, mesh::TreeMesh{3},
equations::AbstractEquationsParabolic,
dg::DG, cache)
@unpack inverse_jacobian = cache.elements

@threaded for element in eachelement(dg, cache)
Expand All @@ -1141,4 +1142,22 @@ function apply_jacobian_parabolic!(du, mesh::Union{TreeMesh{3}, P4estMesh{3}},

return nothing
end

function apply_jacobian_parabolic!(du, mesh::P4estMesh{3},
equations::AbstractEquationsParabolic,
dg::DG, cache)
@unpack inverse_jacobian = cache.elements

@threaded for element in eachelement(dg, cache)
for k in eachnode(dg), j in eachnode(dg), i in eachnode(dg)
factor = inverse_jacobian[i, j, k, element]

for v in eachvariable(equations)
du[v, i, j, k, element] *= factor
end
end
end

return nothing
end
end # @muladd
Loading