Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/improved exports #14

Closed

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented May 20, 2024

Split from #6

  • includes all requested changes from the linked PR related to the changes made in this PR
  • fixes latency naming convention
  • adds timeout
  • improved type exports

Copy link
Contributor

Lines Statements Branches Functions
Coverage: NaN%
Unknown% (0/0) Unknown% (0/0) Unknown% (0/0)

JUnit

Tests Skipped Failures Errors Time
0 0 💤 0 ❌ 0 🔥 2.702s ⏱️
Coverage Report (0%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files0000 

@rndquu
Copy link
Member

rndquu commented May 21, 2024

@Keyrxng Why did you close it?

@Keyrxng
Copy link
Contributor Author

Keyrxng commented May 21, 2024

My mistake @rndquu, I thought that the one you just merged was the only one you needed

@Keyrxng Keyrxng reopened this May 21, 2024
@rndquu
Copy link
Member

rndquu commented May 21, 2024

@Keyrxng

  1. This PR simply removes unused files, correct?
  2. Pls fix the build, the development one is passing

@Keyrxng
Copy link
Contributor Author

Keyrxng commented May 21, 2024

@rndquu just knip to go now

@rndquu
Copy link
Member

rndquu commented May 21, 2024

@rndquu just knip to go now

There are 0 files changed. I don't understand what we should do with this PR.

@Keyrxng
Copy link
Contributor Author

Keyrxng commented May 21, 2024

I created the branch from the commit where I removed the files as that was part of the improving exports, the tests included all commits from this PR which is why I closed it.

I thought I had mistakenly split a PR which shouldn't have been split and you just used the one with all of the changes, I gather I've made a couple of blunders along the way.

This can be closed since it adds nothing of value.

@rndquu rndquu closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants