-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polymorphic with improved exports #6
Conversation
- added rpcTimeout as config option - added test-specific build - fixed bug with latency naming causing chain-agnostic rpc calls
Data tracking feature is fine but I'm personally not concerned with it. Also consider making more precise changes for handling issues. And then opening a separate pull for refactoring and miscellaneous changes. It feels like searching for a needle in a haystack for the reviewers otherwise and it's difficult to focus on the important changes with a pull of this size. |
duly noted! After seeing molecula handle the commit history so clean I thought best to try follow suit but I'm not quite at that level yet eh lmao I'll refactor optionals to default tmrw but I do believe that the |
Co-authored-by: アレクサンダー.eth <[email protected]>
Is there anything holding this back except the merge conflict? If there is I'll handle them together |
I have split this PR into two, one for tests and one for polymorphic exports. If it's easier to review the two split then this could be closed and I'll open the other two, unless that would make further review more difficult. Either way, considering the NPM package is now published and progress can be made in relevant issues it's better to close this as not planned and stick with |
That's right @rndquu |
Relates to ubiquity/pay.ubq.fi#205
package.json
to serve correct module from@ubiquitydao/rpc-handler
rpcTimeout
as config option100
&1
) and executed on.A
to chainB
Allowing the
data-tracking
to be configurable would be a substantial change and would beef the package up quite handsomely because it would require that all RPCs for every chain get injected at build time and then adding a filtering method for returning list of acceptable providers meeting theirdata-tracking
needsWhat's the consensus in adding this feature?