Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 Nav Tube Driver #10

Merged
merged 6 commits into from
Jan 11, 2025
Merged

ROS2 Nav Tube Driver #10

merged 6 commits into from
Jan 11, 2025

Conversation

DaniParr
Copy link
Contributor

@DaniParr DaniParr commented Jan 7, 2025

Adapted cpp code to work with rclcpp for the nav_tube_driver

@DaniParr
Copy link
Contributor Author

DaniParr commented Jan 7, 2025

When I ran the install script on my computer after deleting the colcon build and install folders, I did not have the same issue CI did...

@DaniParr DaniParr requested a review from cbrxyz January 8, 2025 02:47
@cbrxyz
Copy link
Member

cbrxyz commented Jan 8, 2025

Thanks! I'll check it out now! Also, nothing major but @DaniParr, can you name your branches something more descriptive (preferably including your name)? This is a good format <issue/pr number if relevant>-<name>-<brief_description> (ie, 3701-cameron-rubix-cube-solver)

Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.vscode/settings.json Outdated Show resolved Hide resolved
src/subjugator/drivers/nav_tube_driver/CMakeLists.txt Outdated Show resolved Hide resolved
src/subjugator/drivers/nav_tube_driver/package.xml Outdated Show resolved Hide resolved
src/subjugator/drivers/nav_tube_driver/package.xml Outdated Show resolved Hide resolved
src/subjugator/drivers/nav_tube_driver/package.xml Outdated Show resolved Hide resolved
@DaniParr DaniParr requested a review from cbrxyz January 10, 2025 18:26
Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks daniel!

@cbrxyz cbrxyz merged commit a69735d into main Jan 11, 2025
2 checks passed
@cbrxyz cbrxyz deleted the nav_tube_driver branch January 11, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants