Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTD-5823-cta-notes-additional-docs #2327

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

depsiatwal
Copy link
Contributor

@@ -66,4 +66,7 @@ <h1 class="govuk-heading-l">{% block title %}{% lcs 'AdditionalDocuments.TITLE'%
</p>
</div>
{% endif %}
<a class="govuk-button govuk-button--primary" href="{% url 'applications:task_list' application_id %}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content here is "save and continue" but it appears to be taking the user back to their task list. Has this already been saved at this point..?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did wonder about this point as well,

i'll put a note on the ticket and ask what the expectation is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concluded looks like UCD want to keep as "save and continue"

https://uktrade.atlassian.net/browse/LTD-5823

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Thanks for confirming that

@hnryjmes hnryjmes self-requested a review January 23, 2025 10:07
@@ -66,4 +66,7 @@ <h1 class="govuk-heading-l">{% block title %}{% lcs 'AdditionalDocuments.TITLE'%
</p>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-01-23 at 10 20 25

the spacing doesn't look right when there are no additional documents added. I had a similar problem in #2320 which I fixed by making an element appear with the css class lite-information-text__help as that has the margin bottom set which gives the right spacing for the button.

locally because I've got this branch pulled down I just tried adding an empty div <div class="lite-information-text__help"></div> right below the div with lite-information-text on but this is a bit hacky and you might be able to think of a more elegant way to do this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

@hnryjmes hnryjmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't make a line comment for some reason but at line 15 where the button is defined this should now be made grey as there should only be 1 CTA on the page. so where the class says govuk-button you can add govuk-button--secondary and that should do it.

https://github.com/uktrade/lite-frontend/pull/2327/files#diff-8f194965ed2d91978e538af3279b7d72d163fcb853862d1bc4c6e4606bac35e1R15

@depsiatwal depsiatwal force-pushed the LTD-5823-cta-notes-additional-docs branch from a6dc339 to df5959e Compare January 23, 2025 13:40
@depsiatwal
Copy link
Contributor Author

I can't make a line comment for some reason but at line 15 where the button is defined this should now be made grey as there should only be 1 CTA on the page. so where the class says govuk-button you can add govuk-button--secondary and that should do it.

https://github.com/uktrade/lite-frontend/pull/2327/files#diff-8f194965ed2d91978e538af3279b7d72d163fcb853862d1bc4c6e4606bac35e1R15

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants