-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LTD-5823-cta-notes-additional-docs #2327
base: dev
Are you sure you want to change the base?
Conversation
@@ -66,4 +66,7 @@ <h1 class="govuk-heading-l">{% block title %}{% lcs 'AdditionalDocuments.TITLE'% | |||
</p> | |||
</div> | |||
{% endif %} | |||
<a class="govuk-button govuk-button--primary" href="{% url 'applications:task_list' application_id %}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content here is "save and continue" but it appears to be taking the user back to their task list. Has this already been saved at this point..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did wonder about this point as well,
i'll put a note on the ticket and ask what the expectation is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concluded looks like UCD want to keep as "save and continue"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one. Thanks for confirming that
@@ -66,4 +66,7 @@ <h1 class="govuk-heading-l">{% block title %}{% lcs 'AdditionalDocuments.TITLE'% | |||
</p> | |||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the spacing doesn't look right when there are no additional documents added. I had a similar problem in #2320 which I fixed by making an element appear with the css class lite-information-text__help
as that has the margin bottom set which gives the right spacing for the button.
locally because I've got this branch pulled down I just tried adding an empty div <div class="lite-information-text__help"></div>
right below the div with lite-information-text
on but this is a bit hacky and you might be able to think of a more elegant way to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't make a line comment for some reason but at line 15 where the button is defined this should now be made grey as there should only be 1 CTA on the page. so where the class says govuk-button
you can add govuk-button--secondary
and that should do it.
a6dc339
to
df5959e
Compare
Done |
https://uktrade.atlassian.net/browse/LTD-5823
CTA added as per ticket