Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTD-5823-cta-notes-additional-docs #2327

Merged
merged 3 commits into from
Jan 27, 2025
Merged

LTD-5823-cta-notes-additional-docs #2327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df5959e
add cts
depsiatwal Jan 21, 2025
6bbef27
Merge branch 'dev' into LTD-5823-cta-notes-additional-docs
depsiatwal Jan 23, 2025
194ba2a
Merge branch 'dev' into LTD-5823-cta-notes-additional-docs
depsiatwal Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion exporter/templates/applications/additional-documents/additional-documents.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<h1 class="govuk-heading-l">{% block title %}{% lcs 'AdditionalDocuments.TITLE'%}{% endblock %}</h1>
</div>
<div class="lite-app-bar__controls">
<a href="{% url 'applications:attach_additional_document' application_id %}" class="govuk-button" draggable="false" role="button">
<a href="{% url 'applications:attach_additional_document' application_id %}" class="govuk-button govuk-button--secondary" draggable="false" role="button">
{% lcs 'AdditionalDocuments.ADD' %}
</a>
</div>
Expand Down Expand Up @@ -65,5 +65,9 @@ <h1 class="govuk-heading-l">{% block title %}{% lcs 'AdditionalDocuments.TITLE'%
{% lcs 'AdditionalDocuments.NO_RESULTS' %}
</p>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-01-23 at 10 20 25

the spacing doesn't look right when there are no additional documents added. I had a similar problem in #2320 which I fixed by making an element appear with the css class lite-information-text__help as that has the margin bottom set which gives the right spacing for the button.

locally because I've got this branch pulled down I just tried adding an empty div <div class="lite-information-text__help"></div> right below the div with lite-information-text on but this is a bit hacky and you might be able to think of a more elegant way to do this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

<div class="lite-information-text__help"></div>
{% endif %}
<a class="govuk-button govuk-button--primary" href="{% url 'applications:task_list' application_id %}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content here is "save and continue" but it appears to be taking the user back to their task list. Has this already been saved at this point..?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did wonder about this point as well,

i'll put a note on the ticket and ask what the expectation is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concluded looks like UCD want to keep as "save and continue"

https://uktrade.atlassian.net/browse/LTD-5823

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Thanks for confirming that

Save and continue
</a>
{% endblock %}
4 changes: 3 additions & 1 deletion exporter/templates/includes/case-notes.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@
{% else %}
{% include "includes/notice.html" with text="applications.CaseNotes.NO_NOTES" %}
{% endif %}

<a class="govuk-button govuk-button--primary" href="{% url 'applications:task_list' application.id %}">
Save and continue
</a>
<script src="{% static 'javascripts/pluralize.js' %}"></script>
<script src="{% static 'javascripts/case-notes.js' %}"></script>