Tp2000 1616 workflow task create view #1363
Conversation
…task-create-view
…ngo documentation guidelines
| name="task-workflow-task-ui-create", | ||
| ), | ||
| path( | ||
| "task/confirm-create/<int:pk>", |
There was a problem hiding this comment.
For URL pattern consistency with other confirm-create views (for instance, subtask creation uses "subtasks/<int:pk>/confirm-create/",):
| "task/confirm-create/<int:pk>", | |
| "task/<int:pk>/confirm-create/", |
| workflow=self.get_task_workflow(), | ||
| task=self.object, | ||
| ) | ||
| return HttpResponseRedirect(self.get_success_url(), self.object.pk) |
There was a problem hiding this comment.
Is the second parameter to the HttpResponseRedirect constructor correct or needed?
| "progress_state": progress_state.pk, | ||
| } | ||
| create_response = valid_user_client.post(create_url, form_data) | ||
| created_workflow_task = task_workflow.get_tasks().get() |
There was a problem hiding this comment.
There's an assert that checks for a single task count further down, so if this blows up because there isn't exactly one task instance, then that assert will never be applied. The assertion could be performed against task count before getting the (single) task.
Checking the response's status code straight after the call to post() would also usefully catch failures in a more descriptive way, rather than, say, the reverse() failing in a less straightforward way.
|
|
||
| soup = BeautifulSoup(str(confirmation_response.content), "html.parser") | ||
|
|
||
| assert confirmation_response.status_code == 200 |
There was a problem hiding this comment.
Similar to previous comment, before attempting to access the response's content, the assert should first perform its validation checking.
Placement of asserts in the other test, test_workflow_delete_view_deletes_related_tasks, is better because it places them close to the side-effect or invariance they're validating.
TP2000-1616 : Workflow Task Create View
Why
What
TaskWorkflowTaskCreateandTaskWorkflowTaskConfirmCreateTaskIteminstance is created for each Task upon completion to link it to its corresponding workflow and manage queue positiontest_create_workflow_task_viewandtest_workflow_delete_view_deletes_related_tasksChecklist