Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tp2000 1616 workflow task create view #1363
base: TP2000-1471--task-workflow
Are you sure you want to change the base?
Tp2000 1616 workflow task create view #1363
Changes from 6 commits
97f223a
d2feb1b
0bf3eff
cae9f2c
cc2ff3a
d0cef66
b850751
8546b9b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an assert that checks for a single task count further down, so if this blows up because there isn't exactly one task instance, then that assert will never be applied. The assertion could be performed against task count before getting the (single) task.
Checking the response's status code straight after the call to
post()
would also usefully catch failures in a more descriptive way, rather than, say, thereverse()
failing in a less straightforward way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to previous comment, before attempting to access the response's content, the
assert
should first perform its validation checking.Placement of
asserts
in the other test,test_workflow_delete_view_deletes_related_tasks
, is better because it places them close to the side-effect or invariance they're validating.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For URL pattern consistency with other confirm-create views (for instance, subtask creation uses
"subtasks/<int:pk>/confirm-create/",
):There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the second parameter to the
HttpResponseRedirect
constructor correct or needed?