Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4176 customizing reminder message to partners #1

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

nathangthomas
Copy link

Resolves rubyforgood#4176

Description

This PR allows a custom message to be added to the distribution reminder message similar to how we currently make customizations on the distribution email content.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested manually
  • Wrote two tests in the distribution_mailer_spec that account for a distribution that includes a custom_reminder

Provide instructions so we can reproduce.
You can test the email manually by:

  • run the app locally bin/start
  • go to http://localhost:3000/diaper_bank/distributions/1/edit
  • add a custom message and ensure that the distribution date and time is for a date in the future.
  • open rails c
  • run DistributionMailer.reminder_email(Distribution.first.id).deliver_now A mailer preview should open in your browser.

Screenshots

Screenshot 2024-03-14 at 2 53 06 PM Screenshot 2024-03-14 at 2 51 40 PM

@nathangthomas nathangthomas requested review from latortuga and zieski and removed request for latortuga and zieski March 14, 2024 22:36
@gcentauri gcentauri self-requested a review April 1, 2024 15:47
@cielf
Copy link

cielf commented Apr 14, 2024

Hey @nathangthomas -- I see you have two prs related to this, and the second one is WIP. Are you looking to have this one merged, or the second one? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customizing Reminder Message to Partners
2 participants