Skip to content

Use SBG sensor status #273

Use SBG sensor status

Use SBG sensor status #273

GitHub Actions / clippy succeeded Mar 18, 2024 in 1s

clippy

89 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 89
Note 0
Help 0

Versions

  • rustc 1.76.0 (07dca489a 2024-02-04)
  • cargo 1.76.0 (c84b36747 2024-01-18)
  • clippy 0.1.76 (07dca48 2024-02-04)

Annotations

Check warning on line 167 in boards/sensor/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty `loop {}` wastes CPU cycles

warning: empty `loop {}` wastes CPU cycles
   --> boards/sensor/src/main.rs:167:9
    |
167 |         loop {}
    |         ^^^^^^^
    |
    = help: you should either use `panic!()` or add a call pausing or sleeping the thread to the loop body
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop
    = note: `#[warn(clippy::empty_loop)]` on by default

Check warning on line 136 in boards/recovery/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty `loop {}` wastes CPU cycles

warning: empty `loop {}` wastes CPU cycles
   --> boards/recovery/src/main.rs:136:9
    |
136 |         loop {}
    |         ^^^^^^^
    |
    = help: you should either use `panic!()` or add a call pausing or sleeping the thread to the loop body
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop
    = note: `#[warn(clippy::empty_loop)]` on by default

Check warning on line 106 in boards/recovery/src/state_machine/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> boards/recovery/src/state_machine/mod.rs:106:1
    |
106 | impl Into<state::StateData> for RocketStates {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
            https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
    = note: `#[warn(clippy::from_over_into)]` on by default
help: replace the `Into` implementation with `From<state_machine::RocketStates>`
    |
106 ~ impl From<RocketStates> for state::StateData {
107 ~     fn from(val: RocketStates) -> Self {
108 ~         match val {
    |

Check warning on line 134 in boards/sensor/src/sbg_manager.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `[u8; 1024]` which implements the `Copy` trait

warning: using `clone` on type `[u8; 1024]` which implements the `Copy` trait
   --> boards/sensor/src/sbg_manager.rs:134:33
    |
134 |                 let buf_clone = buf.clone();
    |                                 ^^^^^^^^^^^ help: try dereferencing it: `*buf`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `#[warn(clippy::clone_on_copy)]` on by default

Check warning on line 73 in boards/sensor/src/communication.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
  --> boards/sensor/src/communication.rs:64:5
   |
64 | /     pub fn new<S>(
65 | |         can_rx: Pin<PA23, AlternateI>,
66 | |         can_tx: Pin<PA22, AlternateI>,
67 | |         pclk_can: Pclk<Can0, Gclk0Id>,
...  |
72 | |         loopback: bool,
73 | |     ) -> (Self, S::Inc)
   | |_______________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
   = note: `#[warn(clippy::too_many_arguments)]` on by default

Check warning on line 59 in boards/sensor/src/communication.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
  --> boards/sensor/src/communication.rs:54:14
   |
54 |       pub can: Can<
   |  ______________^
55 | |         'static,
56 | |         Can0,
57 | |         Dependencies<Can0, Gclk0Id, Pin<PA23, Alternate<I>>, Pin<PA22, Alternate<I>>, CAN0>,
58 | |         Capacities,
59 | |     >,
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
   = note: `#[warn(clippy::type_complexity)]` on by default

Check warning on line 71 in boards/recovery/src/communication.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
  --> boards/recovery/src/communication.rs:62:5
   |
62 | /     pub fn new<S>(
63 | |         can_rx: Pin<PA23, AlternateI>,
64 | |         can_tx: Pin<PA22, AlternateI>,
65 | |         pclk_can: Pclk<Can0, Gclk0Id>,
...  |
70 | |         loopback: bool,
71 | |     ) -> (Self, S::Inc)
   | |_______________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
   = note: `#[warn(clippy::too_many_arguments)]` on by default

Check warning on line 57 in boards/recovery/src/communication.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
  --> boards/recovery/src/communication.rs:52:14
   |
52 |       pub can: Can<
   |  ______________^
53 | |         'static,
54 | |         Can0,
55 | |         Dependencies<Can0, Gclk0Id, Pin<PA23, Alternate<I>>, Pin<PA22, Alternate<I>>, CAN0>,
56 | |         Capacities,
57 | |     >,
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
   = note: `#[warn(clippy::type_complexity)]` on by default

Check warning on line 72 in boards/recovery/src/state_machine/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variants `DeployDrogue` and `DeployMain` are never constructed

warning: variants `DeployDrogue` and `DeployMain` are never constructed
  --> boards/recovery/src/state_machine/mod.rs:72:5
   |
71 | pub enum RocketEvents {
   |          ------------ variants in this enum
72 |     DeployDrogue,
   |     ^^^^^^^^^^^^
73 |     DeployMain,
   |     ^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 127 in boards/camera/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty `loop {}` wastes CPU cycles

warning: empty `loop {}` wastes CPU cycles
   --> boards/camera/src/main.rs:127:9
    |
127 |         loop {}
    |         ^^^^^^^
    |
    = help: you should either use `panic!()` or add a call pausing or sleeping the thread to the loop body
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop
    = note: `#[warn(clippy::empty_loop)]` on by default

Check warning on line 486 in libraries/sbg-rs/src/sbg.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you seem to be trying to use `match` for an equality check. Consider using `if`

warning: you seem to be trying to use `match` for an equality check. Consider using `if`
   --> libraries/sbg-rs/src/sbg.rs:479:5
    |
479 | /     match logType {
480 | |         // silently handle errors
481 | |         // _SbgDebugLogType_SBG_DEBUG_LOG_TYPE_ERROR => error!("SBG Error"),
482 | |         _SbgDebugLogType_SBG_DEBUG_LOG_TYPE_WARNING => warn!("SBG Warning"),
...   |
485 | |         _ => (),
486 | |     };
    | |_____^ help: try: `if logType == _SbgDebugLogType_SBG_DEBUG_LOG_TYPE_WARNING { warn!("SBG Warning") }`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
    = note: `#[warn(clippy::single_match)]` on by default

Check warning on line 467 in libraries/sbg-rs/src/sbg.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unsafe function's docs miss `# Safety` section

warning: unsafe function's docs miss `# Safety` section
   --> libraries/sbg-rs/src/sbg.rs:459:1
    |
459 | / pub unsafe extern "C" fn sbgPlatformDebugLogMsg(
460 | |     _pFileName: *const ::core::ffi::c_char,
461 | |     _pFunctionName: *const ::core::ffi::c_char,
462 | |     _line: u32,
...   |
466 | |     _pFormat: *const ::core::ffi::c_char,
467 | | ) {
    | |_^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc

Check warning on line 421 in libraries/sbg-rs/src/sbg.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
   --> libraries/sbg-rs/src/sbg.rs:421:23
    |
421 |             Err(_) => return _SbgErrorCode_SBG_READ_ERROR,
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
421 |             Err(_) => _SbgErrorCode_SBG_READ_ERROR,
    |                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 420 in libraries/sbg-rs/src/sbg.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
   --> libraries/sbg-rs/src/sbg.rs:420:22
    |
420 |             Ok(_) => return _SbgErrorCode_SBG_NO_ERROR,
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
420 |             Ok(_) => _SbgErrorCode_SBG_NO_ERROR,
    |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 409 in libraries/sbg-rs/src/sbg.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unsafe function's docs miss `# Safety` section

warning: unsafe function's docs miss `# Safety` section
   --> libraries/sbg-rs/src/sbg.rs:406:5
    |
406 | /     pub unsafe extern "C" fn SbgFlushFunc(
407 | |         pInterface: *mut _SbgInterface,
408 | |         _flags: u32,
409 | |     ) -> _SbgErrorCode {
    | |______________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc

Check warning on line 360 in libraries/sbg-rs/src/sbg.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unsafe function's docs miss `# Safety` section

warning: unsafe function's docs miss `# Safety` section
   --> libraries/sbg-rs/src/sbg.rs:354:5
    |
354 | /     pub unsafe extern "C" fn SbgEComReceiveLogFunc(
355 | |         _pHandle: *mut _SbgEComHandle,
356 | |         msgClass: u32,
357 | |         msg: u32,
358 | |         pLogData: *const _SbgBinaryLogData,
359 | |         _pUserArg: *mut c_void,
360 | |     ) -> _SbgErrorCode {
    | |______________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc

Check warning on line 319 in libraries/sbg-rs/src/sbg.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unsafe function's docs miss `# Safety` section

warning: unsafe function's docs miss `# Safety` section
   --> libraries/sbg-rs/src/sbg.rs:315:5
    |
315 | /     pub unsafe extern "C" fn SbgInterfaceWriteFunc(
316 | |         pInterface: *mut _SbgInterface,
317 | |         pBuffer: *const c_void,
318 | |         bytesToWrite: usize,
319 | |     ) -> _SbgErrorCode {
    | |______________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc

Check warning on line 298 in libraries/sbg-rs/src/sbg.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the loop variable `i` is only used to index `array`

warning: the loop variable `i` is only used to index `array`
   --> libraries/sbg-rs/src/sbg.rs:298:18
    |
298 |         for i in 0..(bytesToRead) {
    |                  ^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
    = note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator
    |
298 |         for <item> in array.iter_mut().take((bytesToRead)) {
    |             ~~~~~~    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 309 in libraries/sbg-rs/src/sbg.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
   --> libraries/sbg-rs/src/sbg.rs:309:9
    |
309 |         return _SbgErrorCode_SBG_NO_ERROR;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
    |
309 -         return _SbgErrorCode_SBG_NO_ERROR;
309 +         _SbgErrorCode_SBG_NO_ERROR
    |

Check warning on line 286 in libraries/sbg-rs/src/sbg.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unsafe function's docs miss `# Safety` section

warning: unsafe function's docs miss `# Safety` section
   --> libraries/sbg-rs/src/sbg.rs:281:5
    |
281 | /     pub unsafe extern "C" fn SbgInterfaceReadFunc(
282 | |         _pInterface: *mut _SbgInterface,
283 | |         pBuffer: *mut c_void,
284 | |         pBytesRead: *mut usize,
285 | |         bytesToRead: usize,
286 | |     ) -> _SbgErrorCode {
    | |______________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
    = note: `#[warn(clippy::missing_safety_doc)]` on by default

Check warning on line 111 in boards/camera/src/state_machine/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> boards/camera/src/state_machine/mod.rs:111:1
    |
111 | impl Into<state::StateData> for RocketStates {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
            https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
    = note: `#[warn(clippy::from_over_into)]` on by default
help: replace the `Into` implementation with `From<state_machine::RocketStates>`
    |
111 ~ impl From<RocketStates> for state::StateData {
112 ~     fn from(val: RocketStates) -> Self {
113 ~         match val {
    |

Check warning on line 113 in boards/power/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty `loop {}` wastes CPU cycles

warning: empty `loop {}` wastes CPU cycles
   --> boards/power/src/main.rs:113:9
    |
113 |         loop {}
    |         ^^^^^^^
    |
    = help: you should either use `panic!()` or add a call pausing or sleeping the thread to the loop body
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop
    = note: `#[warn(clippy::empty_loop)]` on by default

Check warning on line 163 in libraries/sbg-rs/src/data_conversion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

match expression looks like `matches!` macro

warning: match expression looks like `matches!` macro
   --> libraries/sbg-rs/src/data_conversion.rs:160:21
    |
160 |           let valid = match status.get_status() {
    |  _____________________^
161 | |             Some(GpsVelStatusE::SolComputed) => true,
162 | |             _ => false,
163 | |         };
    | |_________^ help: try: `matches!(status.get_status(), Some(GpsVelStatusE::SolComputed))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro

Check warning on line 59 in libraries/sbg-rs/src/data_conversion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

match expression looks like `matches!` macro

warning: match expression looks like `matches!` macro
  --> libraries/sbg-rs/src/data_conversion.rs:56:21
   |
56 |           let valid = match status.get_utc_status() {
   |  _____________________^
57 | |             Some(UtcStatus::Valid | UtcStatus::NoLeapSec) => true,
58 | |             _ => false,
59 | |         };
   | |_________^ help: try: `matches!(status.get_utc_status(), Some(UtcStatus::Valid | UtcStatus::NoLeapSec))`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
   = note: `#[warn(clippy::match_like_matches_macro)]` on by default

Check warning on line 69 in boards/power/src/communication.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
  --> boards/power/src/communication.rs:60:5
   |
60 | /     pub fn new<S>(
61 | |         can_rx: Pin<PA23, AlternateI>,
62 | |         can_tx: Pin<PA22, AlternateI>,
63 | |         pclk_can: Pclk<Can0, Gclk0Id>,
...  |
68 | |         loopback: bool,
69 | |     ) -> (Self, S::Inc)
   | |_______________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
   = note: `#[warn(clippy::too_many_arguments)]` on by default