-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Flux dependencies #3811
Update Flux dependencies #3811
Conversation
cecedff
to
3faa72d
Compare
c5583d7
to
3e20dec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codes around gvks
look good to me.
We need to revisit this, the resulting change is causing applications and sources to appear twice
I don't think we can fix the Summary: If we request My assumption on the reason: I went down to a deep rabbit hole with controller-runtime and stopped when I was in the source code of client-go about handling metadata lists. My assumption (and it matches with our experiences) is, the list query does not care about group versions at all. For example controller-runtime sets the object's gvk to the requested gvk on list. |
In that case, we would
wdyt? |
my only issue with that, it can be misleading, not because "oh that line is different", but given version may not have a specific field, or it has a different type. The UI is presented mostly to people without |
- github.com/fluxcd/kustomize-controller/api v0.34.0 => v1.0.0-rc.4 - github.com/fluxcd/source-controller/api v1.0.0-rc.1 => v1.0.0-rc.5 - github.com/fluxcd/notification-controller/api v0.32.1 => v1.0.0-rc.4 - github.com/fluxcd/pkg/runtime v0.29.0 => v0.39.0 This is so that Weave GitOps can deal with different versions of the API, old and new. As a result of the version bump, controller-runtime was also updated to v0.15.0 which required some changes in the signatures when creating clients. The controller-runtime changes that affected the code were implemented in the following PRs: - https://github.com/kubernetes-sigs/controller-runtime/pull/2150/files - https://github.com/kubernetes-sigs/controller-runtime/pull/2122/files Signed-off-by: Balazs Nadasdi <[email protected]>
Signed-off-by: Balazs Nadasdi <[email protected]>
…it ignores the linter warnings but needless to say this needs to be resolved properly, in a follow-up PR. Signed-off-by: Balazs Nadasdi <[email protected]>
Signed-off-by: Balazs Nadasdi <[email protected]>
Co-authored-by: Balazs Nadasdi <[email protected]>
Closes #3810
What changed?
Updated Flux dependencies.
Why was this change made?
To keep up with Flux changes.
How was this change implemented?
Updated the go modules for the Flux v1 APIs. Also updated code to accommodate controller-runtime version bump.
How did you validate the change?
Run locally
Release notes
N/A
Documentation Changes
N/A