Revert "Update Flux dependencies" #3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a8f791b.
This reverts commit 7f67152.
This reverts commit 5f2b057.
…his commit ignores the linter warnings but needless to say this needs to be resolved properly, in a follow-up PR." This reverts commit 9f4bb9e.
This reverts commit 2011600.
…/fluxcd/kustomize-controller/api v0.34.0 => v1.0.0-rc.4 - github.com/fluxcd/source-controller/api v1.0.0-rc.1 => v1.0.0-rc.5 - github.com/fluxcd/notification-controller/api v0.32.1 => v1.0.0-rc.4 - github.com/fluxcd/pkg/runtime v0.29.0 => v0.39.0" This reverts commit c6f25af.
yiannistri
approved these changes
Jul 6, 2023
Merged
enekofb
reviewed
Jul 24, 2023
| sourcev1beta2.AddToScheme, | ||
| kustomizev1beta2.AddToScheme, | ||
| sourcev1.AddToScheme, | ||
| kustomizev2.AddToScheme, |
There was a problem hiding this comment.
for gitrepository v1 and kustomization v1
There was a problem hiding this comment.
- assume only v1 -> we could support flux v2 but we break < 0.4x
release this
do we have customers asking for backward compatibility ?
in case yes, we could open a ticket to think on supporting backward compatibility as follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3811
This PR requires any dependencies upgrade to controller-runtime 0.15.0 which has many breaking changes:
Maybe we squeeze in one more release before doing that bump?