Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-meetings): numberOfCores stats #3643

Merged
merged 12 commits into from
Jul 18, 2024

Conversation

antsukanova
Copy link
Contributor

@antsukanova antsukanova commented Jun 12, 2024

COMPLETES # WEBEX-379500

This pull request addresses

Missing MQE stats cpuInfo.numberOfCores

by making the following changes

Adds cpuInfo.numberOfCores to MQE to expose the number of logical processors

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

  • unit tests for plugin-meetings
  • manual testing via SDK test app

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@antsukanova antsukanova self-assigned this Jun 12, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3643.d3m3l2kee0btzx.amplifyapp.com

@antsukanova antsukanova force-pushed the antsukan/WEBEX-379500 branch from 5443c87 to eb182a6 Compare June 28, 2024 07:39
@antsukanova antsukanova force-pushed the antsukan/WEBEX-379500 branch from eb182a6 to 0f87ce3 Compare July 11, 2024 12:11
@antsukanova antsukanova added the validated If the pull request is validated for automation. label Jul 11, 2024
@antsukanova antsukanova marked this pull request as ready for review July 11, 2024 12:33
@antsukanova antsukanova requested review from a team as code owners July 11, 2024 12:33
Copy link
Contributor

@edvujic edvujic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Anna, thank you for handling this!

@antsukanova antsukanova requested a review from brycetham July 12, 2024 10:10
@antsukanova antsukanova force-pushed the antsukan/WEBEX-379500 branch from 62730cc to 0b3729c Compare July 15, 2024 15:54
Copy link
Contributor

@brycetham brycetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left an optional comment.

packages/@webex/plugin-meetings/src/statsAnalyzer/index.ts Outdated Show resolved Hide resolved
@antsukanova antsukanova force-pushed the antsukan/WEBEX-379500 branch from 6dff40b to 26a0781 Compare July 16, 2024 06:58
@antsukanova antsukanova force-pushed the antsukan/WEBEX-379500 branch from 341367b to 343f687 Compare July 18, 2024 07:53
@antsukanova antsukanova merged commit cceeb2f into webex:next Jul 18, 2024
11 checks passed
@antsukanova antsukanova deleted the antsukan/WEBEX-379500 branch July 18, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants