Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve test app sdk logic #4054

Merged
merged 6 commits into from
Jan 20, 2025

Conversation

antsukanova
Copy link
Contributor

@antsukanova antsukanova commented Jan 13, 2025

COMPLETES # SPARK-574653

This pull request addresses

This PR adds to the ask sample app logic to have video and audio streams repeat logic from the client team to be able to restore the state before brb was turned on

by making the following changes

  • adds stop screen sharing for brb logic, stores state for video and audio streams.
  • adds logic for resetting the state of media streams if the user turns on the camera/microphone manually.

Logic and testcase overview:
https://app.vidcast.io/share/1ee11b5b-7a99-4f12-b40e-759d14cf3003

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor: SDK sample app change

The following scenarios were tested

  • manual sample app testing

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@antsukanova antsukanova requested review from a team as code owners January 13, 2025 13:45
Copy link

coderabbitai bot commented Jan 13, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@brycetham brycetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small comments :)

docs/samples/browser-plugin-meetings/app.js Show resolved Hide resolved
docs/samples/browser-plugin-meetings/app.js Show resolved Hide resolved
docs/samples/browser-plugin-meetings/app.js Outdated Show resolved Hide resolved
Copy link
Contributor

@edvujic edvujic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than Bryce's comment about the renaming of the variables, LGTM!

@antsukanova antsukanova added the validated If the pull request is validated for automation. label Jan 14, 2025
Copy link
Contributor

@edvujic edvujic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but not blocking.

@antsukanova antsukanova requested a review from sreenara January 15, 2025 11:21
Copy link
Contributor

@sreenara sreenara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm observing an error while trying to click the BRB button when trying this locally. I'm easily able to reproduce it. Just joining a meeting with multistream enabled and then clicking the BRB button. The screenshare stops and then this error occurs

MeetingControls#stopScreenShare()
app.js:3347 MeetingControls#stopScreenShare() :: Successfully stopped sharing!
app.js:3407 meeting.beRightBack({true): error:  TypeError: Cannot set properties of null (setting 'hidden')
    at handleBrbShareMessage (app.js:1772:30)
    at toggleBrb (app.js:3374:9)```

@antsukanova
Copy link
Contributor Author

antsukanova commented Jan 20, 2025

@sreenara thanks for comments, fixed the issue in the console, there is nothing with logic, and just one id was missed for HTML element. It should be fine now. Appreciate your final review.

@antsukanova antsukanova requested a review from sreenara January 20, 2025 10:22
@antsukanova antsukanova merged commit 7c8ed69 into webex:brb-feature Jan 20, 2025
12 checks passed
@antsukanova antsukanova deleted the antsukan/brb-feature-app branch January 20, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants