-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve test app sdk logic #4054
chore: improve test app sdk logic #4054
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some small comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than Bryce's comment about the renaming of the variables, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, but not blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm observing an error while trying to click the BRB button when trying this locally. I'm easily able to reproduce it. Just joining a meeting with multistream enabled and then clicking the BRB button. The screenshare stops and then this error occurs
MeetingControls#stopScreenShare()
app.js:3347 MeetingControls#stopScreenShare() :: Successfully stopped sharing!
app.js:3407 meeting.beRightBack({true): error: TypeError: Cannot set properties of null (setting 'hidden')
at handleBrbShareMessage (app.js:1772:30)
at toggleBrb (app.js:3374:9)```
@sreenara thanks for comments, fixed the issue in the console, there is nothing with logic, and just one id was missed for HTML element. It should be fine now. Appreciate your final review. |
COMPLETES # SPARK-574653
This pull request addresses
This PR adds to the ask sample app logic to have video and audio streams repeat logic from the client team to be able to restore the state before brb was turned on
by making the following changes
Logic and testcase overview:
https://app.vidcast.io/share/1ee11b5b-7a99-4f12-b40e-759d14cf3003
Change Type
The following scenarios were tested
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.