Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve test app sdk logic #4054

Merged
merged 6 commits into from
Jan 20, 2025
Merged

chore: improve test app sdk logic #4054

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f505fe3
chore: improve test app sdk
antsukanova Jan 13, 2025
1882071
chore: improve test app naming
antsukanova Jan 13, 2025
da0f8cf
chore: improve test app share logic for brb
antsukanova Jan 13, 2025
268f232
chore: improve naming and add warning message
antsukanova Jan 14, 2025
2b69663
chore: improve share note message
antsukanova Jan 15, 2025
32c3ec3
chore: fix tag id for test app
antsukanova Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 70 additions & 24 deletions docs/samples/browser-plugin-meetings/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ let receiveTranscriptionOption;
let audioReceiveSlot;
let videoReceiveSlot;
let isMultistream = false;
let isBrb = false;
let localMediaMicMuted = undefined;
let localMediaCameraMuted = undefined;
antsukanova marked this conversation as resolved.
Show resolved Hide resolved
let currentActiveSpeakersMemberIds = [];

const authTypeElm = document.querySelector('#auth-type');
Expand Down Expand Up @@ -857,6 +860,7 @@ const loadCameraBtn = document.querySelector('#ts-load-camera');
const toggleVbgBtn = document.querySelector('#ts-enable-VBG');
const loadMicrophoneBtn = document.querySelector('#ts-load-mic');
const toggleBNRBtn = document.querySelector('#ts-enable-BNR');
const startShareBtn = document.querySelector('#ts-start-screenshare');
const publishShareBtn = document.querySelector('#ts-publish-screenshare');
const unpublishShareBtn = document.querySelector('#ts-unpublish-screenshare');
const stopShareBtn = document.querySelector('#ts-stop-screenshare');
Expand Down Expand Up @@ -1769,7 +1773,10 @@ function toggleSendAudio() {
localMedia.microphoneStream.setUserMuted(newMuteValue);

console.log(`MeetingControls#toggleSendAudio() :: Successfully ${newMuteValue ? 'muted': 'unmuted'} audio!`);
return;

if (isBrb) {
toggleBrb({unmuteOnlyAudio: true});
}
}
}

Expand All @@ -1787,7 +1794,9 @@ function toggleSendVideo() {

console.log(`MeetingControls#toggleSendVideo() :: Successfully ${newMuteValue ? 'muted': 'unmuted'} video!`);

return;
if (isBrb) {
toggleBrb({unmuteOnlyVideo: true});
}
}
}

Expand Down Expand Up @@ -1881,24 +1890,6 @@ async function unpublishScreenShare() {
}
}

async function stopScreenShare() {
console.log('MeetingControls#stopScreenShare()');
try {
if (localMedia.screenShare.audio) {
localMedia.screenShare.audio?.stop();
}
if (localMedia.screenShare.video) {
localMedia.screenShare.video?.stop();
}

console.log('MeetingControls#stopScreenShare() :: Successfully stopped sharing!');
}
catch (error) {
console.log('MeetingControls#stopScreenShare() :: Error stopping screen share!');
console.error(error);
}
}

function setLocalMeetingQuality() {
const audioVideoInputDevices = getAudioVideoInput();

Expand Down Expand Up @@ -3335,21 +3326,76 @@ function toggleBreakout() {
}
}

async function toggleBrb() {
async function stopScreenShare() {
console.log('MeetingControls#stopScreenShare()');
try {
if (localMedia.screenShare.audio) {
localMedia.screenShare.audio?.stop();
}
if (localMedia.screenShare.video) {
localMedia.screenShare.video?.stop();
}

console.log('MeetingControls#stopScreenShare() :: Successfully stopped sharing!');
}
catch (error) {
console.log('MeetingControls#stopScreenShare() :: Error stopping screen share!');
console.error(error);
}
}

async function toggleBrb({unmuteOnlyAudio = false, unmuteOnlyVideo = false}) {
antsukanova marked this conversation as resolved.
Show resolved Hide resolved
const meeting = getCurrentMeeting();

if (meeting) {
const brbButton = document.getElementById('brb-btn');
const enableBrb = brbButton.innerText === 'Step away';

try {
isBrb = enableBrb;

if (enableBrb) {
localMediaCameraMuted = localMedia.cameraStream.userMuted;
localMediaMicMuted = localMedia.microphoneStream.userMuted;

// stop sharing and disable buttons to use it in brb
await stopScreenShare();
publishShareBtn.disabled = true;
unpublishShareBtn.disabled = true;
startShareBtn.disabled = true;
antsukanova marked this conversation as resolved.
Show resolved Hide resolved

localMedia.cameraStream.setUserMuted(true);
localMedia.microphoneStream.setUserMuted(true);

} else {
if (unmuteOnlyAudio) {
localMedia.microphoneStream.setUserMuted(false);
localMediaCameraMuted = undefined;
localMediaMicMuted = undefined;
}

if (unmuteOnlyVideo) {
localMedia.cameraStream.setUserMuted(false);
localMediaCameraMuted = undefined;
localMediaMicMuted = undefined;
}

if (localMediaCameraMuted !== undefined && localMediaMicMuted !== undefined) {
localMedia.cameraStream.setUserMuted(localMediaCameraMuted);
localMedia.microphoneStream.setUserMuted(localMediaMicMuted);
}

// restore user sharing buttons
publishShareBtn.disabled = false;
unpublishShareBtn.disabled = false;
startShareBtn.disabled = false;
}

const result = await meeting.beRightBack(enableBrb);

console.log(`meeting.beRightBack(${enableBrb}): success. Result: ${result}`);
} catch (error) {
console.error(`meeting.beRightBack({${enableBrb}): error: `, error);
} finally {
localMedia?.microphoneStream?.setUserMuted(enableBrb);
localMedia?.cameraStream?.setUserMuted(enableBrb);
}
}
}
Expand Down
Loading