-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESLint Checks for the Repository #50
Conversation
.eslintrc.js
Outdated
@@ -27,7 +27,9 @@ module.exports = { | |||
extends: [ | |||
"plugin:cypress/recommended", | |||
"eslint:recommended", | |||
"plugin:import/typescript" | |||
"plugin:import/typescript", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this working when you run the lint command? @asekawa
plugins: ['@wso2'], // plugin should be added like this
extends: [
'plugin:@wso2/typescript',
'plugin:@wso2/strict',
'plugin:@wso2/internal',
'plugin:@wso2/jest',
'plugin:@wso2/prettier'
],
And once you extend the configs, most of the existing overrides will not be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also install, eslint
, prettier
& jest
as dev dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test the lint command once you do all the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These plugins were installed and tested
"plugin:@wso2/typescript", | ||
"plugin:@wso2/strict", | ||
"plugin:@wso2/internal", | ||
"plugin:@wso2/prettier", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"plugin:@wso2/prettier", | |
"plugin:@wso2/prettier", | |
"plugin:cypress/recommended" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create an issue in https://github.com/brionmario/wso2-ui-configs/issues repo to add a @wso2/cypress
sharable config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purpose
Goals
Approach
Release note
Documentation
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning