Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESLint Checks for the Repository #50

Merged
merged 7 commits into from
Mar 28, 2024
Merged

Add ESLint Checks for the Repository #50

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cb173ec
Add models folder into UI
asekawa Mar 4, 2024
fe99dc5
Add ESLint checks
asekawa Mar 27, 2024
68d0d79
Add ESLint checks for the repository
asekawa Mar 28, 2024
1691ef2
Merge branch 'main' into aw/2
asekawa Mar 28, 2024
a5d808e
Update node version
asekawa Mar 28, 2024
518a659
update package-lock.json
asekawa Mar 28, 2024
e456a67
Add cypress ESlint Checker
asekawa Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ module.exports = {
extends: [
"plugin:cypress/recommended",
"eslint:recommended",
"plugin:import/typescript"
"plugin:import/typescript",
Copy link
Member

@brionmario brionmario Mar 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this working when you run the lint command? @asekawa

plugins: ['@wso2'], // plugin should be added like this
  extends: [
    'plugin:@wso2/typescript',
    'plugin:@wso2/strict',
    'plugin:@wso2/internal',
    'plugin:@wso2/jest',
    'plugin:@wso2/prettier'
  ],

And once you extend the configs, most of the existing overrides will not be needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also install, eslint, prettier & jest as dev dependencies

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test the lint command once you do all the changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These plugins were installed and tested

"plugin:@wso2/prettier",
"plugin:@wso2/eslint-plugin"
],
overrides: [
{
Expand Down
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
"devDependencies": {
"@types/node": "^13.9.2",
"@typescript-eslint/eslint-plugin": "^2.19.2",
"@wso2/eslint-plugin": "https://gitpkg.now.sh/brionmario/wso2-ui-configs/packages/eslint-plugin?5bf60cabe9e9a2571e8b1dd16d0c3bdc76db2c4f",
"@wso2/prettier-config": "https://gitpkg.now.sh/brionmario/wso2-ui-configs/packages/prettier-config?5bf60cabe9e9a2571e8b1dd16d0c3bdc76db2c4f",
"@typescript-eslint/parser": "^2.19.2",
"cypress": "^5.2.0",
"eslint": "^7.4.0",
Expand Down
Empty file added src/ui/models/index.ts
View file
Open in desktop
Empty file.