-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap 5 Renderer #84
Conversation
Refactored as much as I can to meet flake8 requirements. Not sure where to go from here. |
Seems like only two minor issues, left. I will see if I can tweak them. Curiously though, can you explain why this is needed a little better? I use this in a flask app of mine that also uses the flask_bootstrap package and it is working for me. |
Thanks. If I remember correctly, the CSS for Bootstrap 5 changed a bunch of items causing the drop down sub navs to not work? I honestly started the work a while ago and only now put the final touches to get it all working as expected. |
Closing. |
Any details on to why this was closed? |
First of all, I apologize. I thought we had discussed this earlier, but I must have confused it with another PR. I closed it mainly because I don't know off the top of my head how to implement the request you are making, however if you do I would happily accept a PR that doesn't break any existing functionality. |
This doesn't break any current functionality. There is a configuration bool to turn on and use this code path. |
When I build with your previous PR and tested with one of my flask projects, my navigation did not work correctly regardless of whether I specified bootstrap = True, or bootstrap = False. |
I only have the one PR. I'll test with the existing example code to see if I can see why it wouldn't be working. Mind re-opening for work to continue? |
So, I just tried to use the example code out of the box as it sits in this repo. There is no nav bar, just the nav objects. This is because the example code doesn't include any CSS code what so ever to provide drop down or nav bar solutions. I'll investigate getting a working example working and apply to this PR. |
This PR adds a new
BootStrapRenderer
which provides the necessary render functions to work with Bootstrap 5.This is tested using the
bootstrap_flask
python package.When initializing nav, you pass a
bootstrap=True
to the init.