Update Netty to latest version, 4.1.117.Final
#3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
requested review from
jdegoes,
vigoo,
kyri-petrou and
987Nabil
as code owners
guizmaii
force-pushed
the
update_netty
branch
2 times, most recently
from
c674d0b to
c256322
Compare
guizmaii
commented
Jan 19, 2025
Comment on lines
+153
to
+158
| def brotliModeToJava(brotli: CompressionOptions.Mode): BrotliMode = brotli match { | ||
| case CompressionOptions.Mode.Font => BrotliMode.FONT | ||
| case CompressionOptions.Mode.Text => BrotliMode.TEXT | ||
| case CompressionOptions.Mode.Generic => BrotliMode.GENERIC |
There was a problem hiding this comment.
guizmaii
force-pushed
the
update_netty
branch
from
c256322 to
c47b84c
Compare
guizmaii
force-pushed
the
update_netty
branch
from
efdf12c to
eeceb6e
Compare
```scala
- Https Client request - From Trust Store / Client / should throw DecoderException for handshake failure - 36 s 514 ms
✗ ConnectTimeoutException was not List(DecoderException, PrematureChannelClosureException)
<CODE>
hasField = "ConnectTimeoutException"
fails = io.netty.channel.ConnectTimeoutException: connection timed out after 30000 ms: untrusted-root.badssl.com/104.154.89.105:443
input = Failure(
cause = Fail(
value = io.netty.channel.ConnectTimeoutException: connection timed out after 30000 ms: untrusted-root.badssl.com/104.154.89.105:443,
trace = StackTrace(
fiberId = Composite(
left = Runtime(
id = 208992,
startTimeMillis = 1737881442230,
location = "zio.http.ClientHttpsSpecBase.tests.actual(ClientHttpsSpec.scala:66)"
),
right = Runtime(
id = 208991,
startTimeMillis = 1737881442230,
location = "zio.http.ClientHttpsSpecBase.tests(ClientHttpsSpec.scala:65)"
)
),
stackTrace = Chunk("zio.http.ClientHttpsSpecBase.tests.actual(ClientHttpsSpec.scala:66)", "zio.http.ClientHttpsSpecBase.tests.actual(ClientHttpsSpec.scala:66)", "zio.http.ClientHttpsSpecBase.tests(ClientHttpsSpec.scala:67)", "zio.http.ClientHttpsSpecBase.tests(ClientHttpsSpec.scala:65)")
)
)
)
at /home/runner/work/zio-http/zio-http/zio-http/jvm/src/test/scala/zio/http/ClientHttpsSpec.scala:67
```
See https://github.com/zio/zio-http/actions/runs/12973059540/job/36181246408?pr=3279
guizmaii
commented
Jan 26, 2025
| @@ -74,7 +73,7 @@ abstract class ClientHttpsSpecBase extends ZIOHttpSpec { | |||
| ), | |||
| ), | |||
| ) | |||
| } @@ nonFlaky(20), | |||
There was a problem hiding this comment.
This nonFlaky was generating too many calls to https://untrusted-root.badssl.com/, which was leading to connect timeouts (probably some anti-ddos/ratelimiting mechanism there)
|
@987Nabil Ready for review :) |
987Nabil
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://netty.io/news/2025/01/14/4-1-117-Final.html