Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stage): only cache module nodes if they contain children #139

Closed
wants to merge 1 commit into from

Conversation

lukas-mertens
Copy link
Collaborator

@lukas-mertens lukas-mertens commented Apr 12, 2024

Otherwise caching will result in an error, so we skip it in cases where
no children are present.

Closes #84

Signed-off-by: Lukas Mertens [email protected]


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@lukas-mertens lukas-mertens force-pushed the spr/main/30c12ec7 branch 2 times, most recently from 8c7d54a to bfd811d Compare April 15, 2024 09:28
@lukas-mertens lukas-mertens changed the base branch from spr/main/7e4fdb93 to main April 15, 2024 12:11
@lukas-mertens lukas-mertens changed the base branch from main to spr/main/7e4fdb93 April 15, 2024 12:13
Copy link

github-actions bot commented Apr 15, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.18% 15 / 7992
🔵 Statements 0.18% 15 / 7992
🔵 Functions 2.56% 1 / 39
🔵 Branches 9.52% 4 / 42
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/modules/evconf_konva/views/module.ts 0% 0% 0% 0%
Generated in workflow #58

@lukas-mertens lukas-mertens changed the base branch from spr/main/7e4fdb93 to main April 15, 2024 12:28
Otherwise caching will result in an error, so we skip it in cases where
no children are present.

Closes #84

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:30c12ec7
@lukas-mertens
Copy link
Collaborator Author

✓ Commit merged in pull request #164

@lukas-mertens lukas-mertens deleted the spr/main/30c12ec7 branch April 24, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Konva error: Can not cache the node. Width or height of the node equals 0. Caching is skipped.
2 participants