Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(vitest): added setup #147

Closed
wants to merge 1 commit into from

Conversation

lukas-mertens
Copy link
Collaborator

@lukas-mertens lukas-mertens commented Apr 15, 2024

@lukas-mertens lukas-mertens changed the base branch from spr/main/bfa38f6a to main April 15, 2024 12:28
@lukas-mertens lukas-mertens changed the base branch from main to spr/main/bfa38f6a April 15, 2024 12:29
@lukas-mertens lukas-mertens requested a review from nzbr April 19, 2024 13:44
Copy link
Contributor

@nzbr nzbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work on this PR because there are no test present, but it works on #148 without any changes to the config between them

@lukas-mertens
Copy link
Collaborator Author

@nzbr I know, that's why I chose this order: 1. add test setup, 2. add feature + tests, 3. add ci run. This way the diff stays clean/easy to understand but in no commit the pipeline breaks

Closes #143

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:bca4b2b0
@lukas-mertens
Copy link
Collaborator Author

✓ Commit merged in pull request #164

@lukas-mertens lukas-mertens deleted the spr/main/bca4b2b0 branch April 24, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vitest setup
2 participants