Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reusable setup + read node version from nvmrc #164

Merged
merged 21 commits into from
Apr 24, 2024

Conversation

lukas-mertens
Copy link
Collaborator

@lukas-mertens lukas-mertens commented Apr 23, 2024

Closes #145

Addresses the following discussions:

Signed-off-by: Lukas Mertens [email protected]

commit-id:9b48f5ae


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@lukas-mertens lukas-mertens requested review from nzbr and removed request for nzbr April 23, 2024 09:16
@lukas-mertens lukas-mertens force-pushed the spr/main/9b48f5ae branch 2 times, most recently from 37d137f to a596803 Compare April 23, 2024 09:21
@lukas-mertens lukas-mertens requested a review from nzbr April 23, 2024 09:22
@lukas-mertens lukas-mertens self-assigned this Apr 23, 2024
Copy link

github-actions bot commented Apr 23, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.12% 15 / 12196
🔵 Statements 0.12% 15 / 12196
🔵 Functions 2.5% 1 / 40
🔵 Branches 9.3% 4 / 43
File CoverageNo changed files found.
Generated in workflow #53

@lukas-mertens lukas-mertens linked an issue Apr 23, 2024 that may be closed by this pull request
As https://github.com/orgs/community/discussions/12835 is not yet
implemented, we have to do it manually.

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:a07ec8d4
Signed-off-by: Lukas Mertens <[email protected]>

commit-id:850c9225
Signed-off-by: Lukas Mertens <[email protected]>

commit-id:088444aa
Closes #73

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:68e323f6
Closes #103

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:110f685c
Signed-off-by: Lukas Mertens <[email protected]>

commit-id:2f10d1b6
…verest framework

Closes #131

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:bb068b2d
Closes #133

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:bfa38f6a
Closes #143

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:bca4b2b0
Closes #107

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:0bb94152
Closes #144

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:0e59297c
Signed-off-by: Lukas Mertens <[email protected]>

commit-id:b8a1b2d2
Closes #137

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:7e4fdb93
Otherwise caching will result in an error, so we skip it in cases where
no children are present.

Closes #84

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:30c12ec7
Otherwise users accidently click on the link and think it does not work

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:de0b76a1
Closes #151

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:b922e502
Closes #150

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:002631eb
Closes #156

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:4c4eb3f1
In most cases the random wait doesn't help, as users just want to use
the admin panel, not test how it reacts to bad network condition. For
now I just reduced it, maybe later we can add a toggle

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:fdcfca23
Closes #145

Addresses the following discussions:
 - #148 (comment)
 - #148 (comment)

Signed-off-by: Lukas Mertens <[email protected]>

commit-id:9b48f5ae
@lukas-mertens lukas-mertens changed the base branch from spr/main/fdcfca23 to main April 24, 2024 16:22
@lukas-mertens lukas-mertens merged commit c8be7f4 into main Apr 24, 2024
7 checks passed
@lukas-mertens lukas-mertens deleted the spr/main/9b48f5ae branch April 24, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor CI for less code duplication
2 participants