generated from EVerest/everest-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: reusable setup + read node version from nvmrc #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2024
lukas-mertens
force-pushed
the
spr/main/9b48f5ae
branch
2 times, most recently
from
April 23, 2024 09:21
37d137f
to
a596803
Compare
Coverage Report
File CoverageNo changed files found. |
nzbr
approved these changes
Apr 23, 2024
lukas-mertens
force-pushed
the
spr/main/fdcfca23
branch
from
April 23, 2024 13:28
f05e98d
to
94c95fe
Compare
lukas-mertens
force-pushed
the
spr/main/9b48f5ae
branch
from
April 23, 2024 13:28
a596803
to
3696c87
Compare
As https://github.com/orgs/community/discussions/12835 is not yet implemented, we have to do it manually. Signed-off-by: Lukas Mertens <[email protected]> commit-id:a07ec8d4
Signed-off-by: Lukas Mertens <[email protected]> commit-id:850c9225
Signed-off-by: Lukas Mertens <[email protected]> commit-id:088444aa
Signed-off-by: Lukas Mertens <[email protected]> commit-id:14f3764c
Closes #73 Signed-off-by: Lukas Mertens <[email protected]> commit-id:68e323f6
Closes #103 Signed-off-by: Lukas Mertens <[email protected]> commit-id:110f685c
Signed-off-by: Lukas Mertens <[email protected]> commit-id:2f10d1b6
…verest framework Closes #131 Signed-off-by: Lukas Mertens <[email protected]> commit-id:bb068b2d
Closes #133 Signed-off-by: Lukas Mertens <[email protected]> commit-id:bfa38f6a
Closes #143 Signed-off-by: Lukas Mertens <[email protected]> commit-id:bca4b2b0
Closes #107 Signed-off-by: Lukas Mertens <[email protected]> commit-id:0bb94152
Closes #144 Signed-off-by: Lukas Mertens <[email protected]> commit-id:0e59297c
Signed-off-by: Lukas Mertens <[email protected]> commit-id:b8a1b2d2
Closes #137 Signed-off-by: Lukas Mertens <[email protected]> commit-id:7e4fdb93
Otherwise caching will result in an error, so we skip it in cases where no children are present. Closes #84 Signed-off-by: Lukas Mertens <[email protected]> commit-id:30c12ec7
Otherwise users accidently click on the link and think it does not work Signed-off-by: Lukas Mertens <[email protected]> commit-id:de0b76a1
Closes #151 Signed-off-by: Lukas Mertens <[email protected]> commit-id:b922e502
Closes #150 Signed-off-by: Lukas Mertens <[email protected]> commit-id:002631eb
Closes #156 Signed-off-by: Lukas Mertens <[email protected]> commit-id:4c4eb3f1
In most cases the random wait doesn't help, as users just want to use the admin panel, not test how it reacts to bad network condition. For now I just reduced it, maybe later we can add a toggle Signed-off-by: Lukas Mertens <[email protected]> commit-id:fdcfca23
Closes #145 Addresses the following discussions: - #148 (comment) - #148 (comment) Signed-off-by: Lukas Mertens <[email protected]> commit-id:9b48f5ae
lukas-mertens
force-pushed
the
spr/main/9b48f5ae
branch
from
April 23, 2024 13:38
3696c87
to
fa3c977
Compare
lukas-mertens
force-pushed
the
spr/main/fdcfca23
branch
from
April 23, 2024 13:38
94c95fe
to
3b1912f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145
Addresses the following discussions:
Signed-off-by: Lukas Mertens [email protected]
commit-id:9b48f5ae
Stack: