chore: Update codeowners to match EM agreed ownership #4750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desi
force-pushed
the
chore/dm-update-codeowners
branch
4 times, most recently
from
082549a to
e6a3571
Compare
desi
force-pushed
the
chore/dm-update-codeowners
branch
from
e6a3571 to
553e3b6
Compare
mindofmar
previously approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Product Safety looks good, cc @AugmentedMode for visibility
Mrtenz
previously approved these changes
Oct 1, 2024
Prithpal-Sooriya
previously approved these changes
Oct 1, 2024
mathieuartu
previously approved these changes
Oct 2, 2024
matthewwalsh0
previously approved these changes
Oct 2, 2024
MajorLift
reviewed
Oct 2, 2024
MajorLift
reviewed
Oct 2, 2024
darkwing
previously approved these changes
Oct 2, 2024
- Organize by team ownership - Update notfications controller to be snaps - Add snaps to permissions controller
desi
dismissed stale reviews from darkwing, matthewwalsh0, mathieuartu, Prithpal-Sooriya, Gudahtt, Mrtenz, gantunesr, and mindofmar
via
0b18247
MajorLift
previously approved these changes
Oct 2, 2024
Co-authored-by: Frederik Bolding <[email protected]>
MajorLift
approved these changes
Oct 2, 2024
FrederikBolding
approved these changes
Oct 2, 2024
matthewwalsh0
approved these changes
Oct 2, 2024
DDDDDanica
approved these changes
Oct 2, 2024
Prithpal-Sooriya
approved these changes
Oct 2, 2024
Mrtenz
approved these changes
Oct 2, 2024
4 tasks
MajorLift
added a commit
that referenced
this pull request
Oct 30, 2024
…le (#4876) ## Explanation - Applies change that was intended to be included in #4750. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Changelog No user-facing changes. ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
We, the MetaMask team (holistically), have recently spent time discussing code ownership around the packages in core. As a team we have aligned on which teams own which packages/controllers within core. This PR is to reflect that alignment. Additionally, in order to not make releasing challenging for the Wallet Framework (who are the stewards of the core repo) we have added this team as codeowners of the manifest file and the changelog file for all packages.
For a little context being code owners doesn’t mean you are the only ones who work in that code but rather that you will take responsibility for making sure that the code is maintained, healthy, up to date and that others contributing to it do so in a manner that is aligned with our guidelines, processes and principles.
References
Checklist