Implementatin mpsks clients

[agmes4]

Content

Sipa implementation for mpsk clients so users can create delete and change them on there own

Please make sure though you did the following (tick off everything you
already did):

• Run the tests and see them pass
• Rebase your branch on top of develop
• Include tests for features you introduced / bugs you fixed

[codecov]

Codecov Report

Attention: Patch coverage is 75.17730% with 35 lines in your changes missing coverage. Please review.

Project coverage is 31.84%. Comparing base (e4b2c30) to head (32b756b).

Files with missing lines	Patch %	Lines
sipa/blueprints/usersuite.py	69.09%	17 Missing ⚠️
sipa/model/pycroft/user.py	33.33%	8 Missing ⚠️
sipa/model/pycroft/api.py	50.00%	4 Missing ⚠️
sipa/model/sample/user.py	73.33%	4 Missing ⚠️
sipa/forms.py	83.33%	1 Missing ⚠️
sipa/model/user.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #504      +/-   ##
===========================================
+ Coverage    31.65%   31.84%   +0.19%     
===========================================
  Files           68       69       +1     
  Lines         6951     7239     +288     
===========================================
+ Hits          2200     2305     +105     
- Misses        4751     4934     +183     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lukasjuhrich]

Checklist / still missing:

• Tests
• translations

[lukasjuhrich]

what precisely is the point of introducing displayable to set it to False in the sample backend?
I'm not sure what this is supposed to achieve.

[agmes4]

otherwise it will try to display the clients which is not feasible cause of there amount. So I Tried to mitigate this by introducing the displayable. But forgot it in the pycorft backend

[FestplattenSchnitzel]

I can't enter the usersuite unfortunately:

CRITICAL 2024-12-27 11:56:04,613 sipa.blueprints.generic Backend error: pycroft
Traceback (most recent call last):
  File "/tmp/sipa/sipa/model/pycroft/user.py", line 44, in __init__
    self.user_data: UserData = UserData.model_validate(user_data)
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/sipa/venv/lib/python3.12/site-packages/pydantic/main.py", line 503, in model_validate
    return cls.__pydantic_validator__.validate_python(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pydantic_core._pydantic_core.ValidationError: 1 validation error for UserData
mpsk_clients
  Field required [type=missing, input_value={'birthdate': '1111-11-11..., 'wifi_password': None}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.4/v/missing

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/tmp/sipa/venv/lib/python3.12/site-packages/flask/app.py", line 880, in full_dispatch_request
    rv = self.dispatch_request()
         ^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/sipa/venv/lib/python3.12/site-packages/flask/app.py", line 865, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)  # type: ignore[no-any-return]
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/sipa/sipa/blueprints/generic.py", line 143, in login
    user = User.authenticate(username, password)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/sipa/sipa/model/pycroft/user.py", line 78, in authenticate
    user = cls.get(result['id'])
           ^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/sipa/sipa/model/pycroft/user.py", line 57, in get
    return cls(user_data)
           ^^^^^^^^^^^^^^
  File "/tmp/sipa/sipa/model/pycroft/user.py", line 47, in __init__
    raise PycroftBackendError("Error when parsing user lookup response") from e
sipa.model.pycroft.exc.PycroftBackendError: Error when parsing user lookup response

[agmes4]

interesting yesterday it worked for me will check

[agmes4]

just forgot to push a naming change sorry

[FestplattenSchnitzel]

Unfortunately, the error persists. Are you using a modified version of Pycroft? The error occurs b/c there is no mpsk_clients field in the data returned by the Pycroft API.

[hw0lff]

The base functionality and localisation works as far as I could see and test.
It's not perfect, e.g. the form to delete and create MPSK clients is the same and has the same title for both.
However, this can be fixed later.