Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Publication]: Error notifications adjustment #1481

Closed
1 task done
YauheniyaH opened this issue Jun 3, 2024 · 5 comments
Closed
1 task done

[Publication]: Error notifications adjustment #1481

YauheniyaH opened this issue Jun 3, 2024 · 5 comments
Assignees
Labels
bug Something isn't working _priority_2

Comments

@YauheniyaH
Copy link

YauheniyaH commented Jun 3, 2024

EPAM AI DIAL chat version

0.12.0

How to reproduce

Case1:
Precondition:
user has chat01
user create 2 or more publication requests for chat01 ( the same requests, to the same path)

Steps:

  1. admin approve one of the publication requests for chat01
  2. admin click Approve button for another publication request for chat01 ->error message "Publication approving failed." -> bug

Case2:
Precondition:
user has folder01 with chat01, chat02, chat03 in it
user created publish request for the folder
admin approve publish request

Steps:

  1. user create another publish request for the folder01 - > error message "Publication failed. Please try again later" -> bug

Case 3
Stesp:

  1. user created chat01
  2. user created publish request for chat into new folder01 inside Organization ( Publish to Organization/folder01/chat01)
  3. user set filter for folder01, which is nit available for himself ( e.g. user is developer, but filter is only for BA)
  4. admin approves the publish request
  5. user create another publish request for any chat to the same folder01 -> error message "Rules uploading failed"
image

Actual result

Error messages do not give explanation why publish requests can not be made

Expected result

Error message should contain meaningful description of the case happen and how it can be avoided of fixed ( if applicable)

Confidential information

  • I confirm that do not share any confidential information
@YauheniyaH
Copy link
Author

Case 4

Steps:

  1. crate folder01 with chat01
  2. create publish request for folder01 with some rules
  3. admin approve publication request
  4. user create unpublish request for folder01
  5. admin approve unpublish request
  6. user create new folder01 with chat01

Actual result: error message appears "Rules uploading failed". It happens because when unpublish folder, then rules applied to this folder are not removed. Also submit request fail with error

Expected result: TBD need to create error message which will be informative for user but not expose folder name or other info about inner storage structure

@Gimir Gimir self-assigned this Jul 24, 2024
@Gimir Gimir moved this to In Progress in AI DIAL Jul 24, 2024
@YauheniyaH
Copy link
Author

Preconditions:
user published Chat01 with File01, chat available in Organization section

Steps:

  1. User rename Chat01 to Chat01_remaned
  2. user create publish request to the same path as Chat01 was published
  3. send request

Actual result: error message is displayed that publication can be performed. This happen because there is already published chat with the same file name to the same path

@Gimir Gimir moved this from In Progress to Code Review in AI DIAL Jul 29, 2024
Gimir added a commit that referenced this issue Aug 1, 2024
… (#1840)

Co-authored-by: Magomed-Elbi Dzhukalaev <[email protected]>
Co-authored-by: Ilya Bondar <[email protected]>
@Gimir Gimir moved this from Code Review to In Testing in AI DIAL Aug 1, 2024
@YauheniyaH
Copy link
Author

for described case 2 return error toast message with text '400'

Image

@YauheniyaH YauheniyaH moved this from In Testing to In Progress in AI DIAL Aug 2, 2024
@YauheniyaH
Copy link
Author

all errors return text as mentioned above

Gimir added a commit that referenced this issue Aug 8, 2024
Co-authored-by: Magomed-Elbi Dzhukalaev <[email protected]>
Co-authored-by: Ilya Bondar <[email protected]>
@VolhaBazhkova
Copy link

VolhaBazhkova commented Aug 12, 2024

Verified on staging environment with the following results:
Case 1:
image
Case 2:
image
Case3:
image
Case4: (there is a misprint in the last step - another user should create the same folder in change path while publishing)
image
Case5:
image

Reported #1915 and discussing with the team the wording of the message (it seems to be strange to show the path and %20) Reported to core: epam/ai-dial-core#442

Reported #1944
Please note, that error messages were updated on UI. Now there are no %20 Example:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working _priority_2
Projects
Status: Done
Development

No branches or pull requests

3 participants