Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken CI jobs on pybind11 branch. #1260

Merged
merged 23 commits into from
Jun 25, 2024
Merged

Fix broken CI jobs on pybind11 branch. #1260

merged 23 commits into from
Jun 25, 2024

Conversation

joaander
Copy link
Member

Description

To the extent possible, fix the currently broken CI builds.

Motivation and Context

It would be nice to fix failing CI checks one at a time instead of all at once.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

joaander added 5 commits June 24, 2024 09:36
@joaander
Use static_cast.
ea1102e
@joaander
Add nanobind to unit test environment.
77a495a
@joaander
Convert readthedocs build to pip.
423f497
@joaander
Use reinterpret_cast
b48ac3e
@joaander
Force usage of clang-tidy-10
bf82c81 
For compatibility to existing code checks.

A later PR can bump this by changing the version of clang-tidy in
.pre-commit.yaml and the github actions runner version in
style_check.yml.
Base automatically changed from pybind11-parallel to pybind11 June 24, 2024 14:15
@joaander joaander mentioned this pull request Jun 24, 2024
Closed
11 tasks
@joaander joaander force-pushed the pybind11-fix-ci branch 2 times, most recently from 2d95bfb to 55037fb Compare June 24, 2024 14:55
@joaander joaander marked this pull request as ready for review June 24, 2024 18:37
@joaander joaander requested review from a team as code owners June 24, 2024 18:37
@joaander joaander requested review from bdice and removed request for a team June 24, 2024 18:37
tommy-waltmann
tommy-waltmann requested changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@tommy-waltmann tommy-waltmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, it will be nice to have unit tests running again with only the converted modules.

.github/workflows/run_tests.yml Show resolved Hide resolved
.github/workflows/style_check.yml Show resolved Hide resolved
.github/workflows/style_check.yml Show resolved Hide resolved
cpp/box/export_Box.h Show resolved Hide resolved
cpp/order/SolidLiquid.h Show resolved Hide resolved
cpp/box/Box.h Show resolved Hide resolved
@tommy-waltmann tommy-waltmann merged commit 6f69a07 into pybind11 Jun 25, 2024
26 checks passed
@tommy-waltmann tommy-waltmann deleted the pybind11-fix-ci branch June 25, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommy-waltmann tommy-waltmann tommy-waltmann approved these changes

@bdice bdice Awaiting requested review from bdice bdice was automatically assigned from glotzerlab/freud-maintainers

Assignees
No one assigned
Labels
build_wheels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaander @tommy-waltmann