Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: naive debouncing for pininterrupt example #2233

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ysoldak
Copy link
Contributor

@ysoldak ysoldak commented Nov 5, 2021

I found it annoying to have no debouncing implemented in the pininterrupt example, so I've implemented it.

Context: @soypat PR about interrupts #2215

Sharing for fun, but you may find it useful to have in the example.
Feel free to bounce the PR, haha.

@ysoldak ysoldak force-pushed the example-pininterrupt-debounce branch from 8e87ba6 to 2ba8542 Compare November 12, 2021 21:40
@ysoldak ysoldak force-pushed the example-pininterrupt-debounce branch 3 times, most recently from b40356c to 12acb04 Compare June 26, 2023 13:33
Copy link
Contributor

@soypat soypat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@deadprogram
Copy link
Member

@ysoldak is this PR something you are still wanting/working on?

@ysoldak ysoldak force-pushed the example-pininterrupt-debounce branch from 12acb04 to 9a07dd5 Compare January 8, 2025 19:19
@ysoldak ysoldak force-pushed the example-pininterrupt-debounce branch from 9a07dd5 to d245fa7 Compare January 8, 2025 20:01
@ysoldak
Copy link
Contributor Author

ysoldak commented Jan 8, 2025

@deadprogram
Rebased on dev and made it pass the tests.
I believe this change makes it easier for people to use the example and shows directly what debouncing is about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants