Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition of "noiseVarianceHomogeneous" -> "errorVarianceHomogeneous" #192

Merged
merged 2 commits into from
Oct 6, 2014

Conversation

cmaumet
Copy link
Member

@cmaumet cmaumet commented Oct 3, 2014

Proposed definition:

nidm:noiseVarianceHomogeneous: "A boolean value that indicates whether the variance of the noise is modelled as being constant throughout the observations used in the model parameters estimation."

(This issue is a companion for #176).

@nicholst
Copy link
Contributor

nicholst commented Oct 1, 2014

What about this:

nidm:noiseVarianceHomogeneous: "A boolean value regarding how the variance of the noise is modelled during parameter estimation; TRUE for constant variance over all observations in the model, FALSE for heterogeneous variance."

@cmaumet
Copy link
Member Author

cmaumet commented Oct 2, 2014

+1

@cmaumet
Copy link
Member Author

cmaumet commented Oct 2, 2014

Maybe to be consistent with #193, we could use "variance of the error" instead of "variance of the noise"?

@nicholst
Copy link
Contributor

nicholst commented Oct 2, 2014

+++1! In fact, I'd be for making a wholesale change, Noise->Error, for all of the "Noise" terms listed in #176 @ elsewhere (e.g. GoogleFight "Error Variance" vs "Noise Variance")

Though I think the language is "Model for the (random) error"
instead of "Noise Model".

What do people think?

@cmaumet
Copy link
Member Author

cmaumet commented Oct 2, 2014

+1 for changing "noise" in "error" in all the "Noise Model" terms.

@khelm
Copy link
Contributor

khelm commented Oct 2, 2014

+1, I guess. i'm basically persuaded by the discussion above and agree that "error" is more inclusive than "noise". I'm more used to hearing about "modelling the noise", though that just may be due to my background and a Google search shows that a number of the top hits are for modeling of actual (acoustic) noise - which is also a point in the favor of "error".

@cmaumet cmaumet force-pushed the errorVarianceHomogeneous branch from bdc0dc1 to d838a5f Compare October 3, 2014 09:45
@cmaumet
Copy link
Member Author

cmaumet commented Oct 3, 2014

Great! The following is now implemented:

nidm:errorVarianceHomogeneous: "A boolean value regarding how the variance of the error is modelled during parameter estimation; TRUE for constant variance over all observations in the model, FALSE for heterogeneous variance."

I positioned the curation status to Pending final vetting "Pending final vetting". @khelm: if you also agree with this definition I think we could move to "Ready for release". What do you think?

@cmaumet cmaumet force-pushed the errorVarianceHomogeneous branch 5 times, most recently from 18d191b to b44d554 Compare October 3, 2014 10:39
@khelm
Copy link
Contributor

khelm commented Oct 3, 2014

Could we change "regarding" to "reflecting"?

@cmaumet
Copy link
Member Author

cmaumet commented Oct 3, 2014

+1

@nicholst
Copy link
Contributor

nicholst commented Oct 4, 2014

+1 for reflecting

@cmaumet cmaumet changed the title Definition of "noiseVarianceHomogeneous" Definition of "noiseVarianceHomogeneous" -> "errorVarianceHomogeneous" Oct 6, 2014
@cmaumet
Copy link
Member Author

cmaumet commented Oct 6, 2014

Thank you @nicholst and @khelm.

The following is now implemented and ready for release:

  • nidm:errorVarianceHomogeneous: "A boolean value relecting how the variance of the error is modelled during parameter estimation; TRUE for constant variance over all observations in the model, FALSE for heterogeneous variance."

@cmaumet cmaumet force-pushed the errorVarianceHomogeneous branch from 49f639e to 6a596ae Compare October 6, 2014 08:03
@cmaumet cmaumet force-pushed the errorVarianceHomogeneous branch from 6a596ae to 5815b29 Compare October 6, 2014 08:10
cmaumet pushed a commit that referenced this pull request Oct 6, 2014
Definition of "noiseVarianceHomogeneous" -> "errorVarianceHomogeneous"
@cmaumet cmaumet merged commit c3ec889 into incf-nidash:master Oct 6, 2014
@cmaumet cmaumet deleted the errorVarianceHomogeneous branch October 6, 2014 08:12
@khelm
Copy link
Contributor

khelm commented Oct 6, 2014

Wait I thought it was going to be: "A boolean value reflecting how the variance of the error is modeled during parameter estimation; TRUE for constant variance over all observations in the model, FALSE for heterogeneous variance."
*reflecting" rather than "regarding"
also "modeling" without the extra "l"

@khelm
Copy link
Contributor

khelm commented Oct 6, 2014

Sorry, I meant "modeled"

@cmaumet
Copy link
Member Author

cmaumet commented Oct 6, 2014

Hi @khelm, you are right it is "reflecting" not "regarding" (the implementation was correct). I have just updated my comment above.

I have just committed to master to correct "modelled" in "modeled", thank you for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants