-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ibex bumped to CHERIoT ISA v1 #383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marnovandermaas
force-pushed
the
ibex_v1
branch
3 times, most recently
from
January 23, 2025 11:38
9e2acfb
to
17dbf17
Compare
Update code from upstream repository https://github.com/lowrisc/cheriot-ibex.git to revision 515481d29a4b927548498bd314a704340adb1ca3 * Verilator width resolution (Marno van der Maas) * Nix formatting (Marno van der Maas) * Feed RV32M through ibexc_top_tracing/ibexc_top (Greg Chadwick) * Switch to no bitmanip by default (Greg Chadwick) * RV32B parameter now passed in ibexc_top (Marno van der Maas) * Add UNOPTFLAT waiver to ibex_id_stage (Adrian Lees) * Patched prim_arbiter.vlt file (Adrian Lees) * Patch to add UNOPTFLAT waiver to prim_arbiter_ppc (Adrian Lees) * [rtl] Fix ICache scramble key valid input (Greg Chadwick) * [rtl] Enable use of ICache with ibexc_top (Greg Chadwick) * [util] Update check_tool_requirements.py (Gary Guo) * Update lowrisc_ip to lowRISC/opentitan@f235838a9e (Marno van der Maas) * Added patch to remove alert prim from all group (Marno van der Maas) * [vendor] Patch updated based on OpenTitan/36a2d3c (Marno van der Maas) * [dv] Alter cov_merge.tcl patch so icache coverage collection works (Greg Chadwick) * Add patch for lowrisc_ip (Harry Callahan) * [vendor] Update patch file based on upstream OpenTitan (Marno van der Maas) * Feed CHERI errors out to top module (Marno van der Maas) * Remove prim alert from build (Marno van der Maas) * Fix tracing (Marno van der Maas) * Update two port RAM for Sonata (Marno van der Maas) * Patch reading memory files taken from upstream (Marno van der Maas) * Various Verilator lint patches (Marno van der Maas) * Use ibexc_top since that is used in SAFE (Marno van der Maas) * Add FPGA primitives (Marno van der Maas) * Bump jinja2 from 3.1.4 to 3.1.5 in /dv/formal (dependabot[bot]) * Bump mako from 1.1.6 to 1.2.2 in /dv/formal (dependabot[bot]) * Formal verification flow for CHERIoT Ibex (mndstrmr) * fixed typos in previous commit (cheri_regfile) (kliuMsft) * fixed issue lowrisc/cheriot-ibex#59 (kliuMsft) * added support for the new cap bounds encoding (implict T8) and the corresponding top-level parameter CheriCapIT8 (kliuMsft) * Minor fixes in ibex_tracer for rv32 mode (kliuMsft) * Add default parameters to fix build under Xcelium (Greg Chadwick) * Update GitHub upload-artifact action to v4 (Nathaniel Wesley Filardo) * minor sv style cleanup (kliuMsft) * changes to align with ISA 1.0 release (kliuMsft) * Base correction only needs one bit (Marno van der Maas) * fixed rvfi_rd_addr for c.srai64 and c.slli64 (kliuMsft) * fixed bit extension instr decoding (issue lowrisc/cheriot-ibex#47) (kliuMsft) * fixed decoder for illegal_reg_cheri/rv32e generation in the case of use_rs3 instructions (kliuMsft) * PVIO needs 3 bit indexes not 4 (Marno van der Maas) * cheri_ex_err_info flop signals weren't used (Marno van der Maas) * added another yml (Nazerke Turtayeva) * adding files (Nazerke Turtayeva) Signed-off-by: Marno van der Maas <[email protected]>
marnovandermaas
force-pushed
the
ibex_v1
branch
from
January 23, 2025 11:53
17dbf17
to
9558051
Compare
marnovandermaas
force-pushed
the
ibex_v1
branch
from
January 23, 2025 12:14
cb20e02
to
3437756
Compare
elliotb-lowrisc
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please give a reason for these lint disabling thingamajigs
These are introduced upstream and are relatively harmless.
marnovandermaas
force-pushed
the
ibex_v1
branch
from
January 23, 2025 12:32
3437756
to
d567ebd
Compare
Hopefully that's better. |
This is introduced upstream and mainly indicates that Verilator cannot simulate this efficiently. Functionality is fine though.
marnovandermaas
force-pushed
the
ibex_v1
branch
from
January 23, 2025 12:42
d567ebd
to
db22f79
Compare
elliotb-lowrisc
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings our CHERIoT Ibex up to ISA v1. This is the last part that is necessary for making Sonata v1.1 release.