Rumble to Intake #71
Merged
Rumble to Intake #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driver controller rumbles when feeder sensor senses note and intake stops
TAKBS2412
reviewed
Feb 27, 2024
jamesdooley4
requested changes
Feb 27, 2024
src/main/java/frc/team2412/robot/commands/intake/AllInCommand.java
Outdated
Show resolved
Hide resolved
addressing comments by adding AllInRumbleCommand
src/main/java/frc/team2412/robot/commands/intake/AllInRumbleCommand.java
Outdated
Show resolved
Hide resolved
intaking without sensors for auto usage
TAKBS2412
reviewed
Feb 28, 2024
src/main/java/frc/team2412/robot/commands/intake/AllInRumbleCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/commands/intake/AllInCommand.java
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
ignore this actually
All rollers reject after intake sensor logic and we included rumble through different stages
no rumbling during auto
jamesdooley4
requested changes
Mar 12, 2024
src/main/java/frc/team2412/robot/commands/intake/AllInCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/commands/intake/AllInCommand.java
Outdated
Show resolved
Hide resolved
rumble debugging- rumbles during auto (will fix that later), increased rumble time, rumble to both controllers
TAKBS2412
requested changes
Mar 13, 2024
src/main/java/frc/team2412/robot/commands/intake/AllInCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/commands/intake/AllInCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/team2412/robot/subsystems/IntakeSubsystem.java
Outdated
Show resolved
Hide resolved
added intake sensors to shuffleboard, removed intake back sensor, changed motor configuration and stopped continuous rumbling
TAKBS2412
previously approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Approving to have a baseline before robot testing.
Note that the rumbled variables like rumbledIntakeFront aren't reset back to false once the command ends, so the controller will only rumble the first time the robot intakes a note on a given side. That can be fixed in a later PR though.
bobtseattle
previously approved these changes
Mar 19, 2024
src/main/java/frc/team2412/robot/subsystems/IntakeSubsystem.java
Outdated
Show resolved
Hide resolved
jamesdooley4
previously approved these changes
Mar 19, 2024
bobtseattle
previously approved these changes
Mar 19, 2024
|
@Yumnah2 - I pushed commits to resolve the merge conflicts & autofix the spotless syntax updates |
jamesdooley4
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.